Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make evaluation run a context manager instead of a singleton. #3529

Merged
merged 9 commits into from
Jul 11, 2024
Merged

Make evaluation run a context manager instead of a singleton. #3529

merged 9 commits into from
Jul 11, 2024

Conversation

nick863
Copy link
Member

@nick863 nick863 commented Jul 9, 2024

Description

In this PR we are doing three things:

  1. Making evaluator run a context manager
  2. Moving function, writing properties to the run history to the evaluation run as a method
  3. Removing code to keep evaluator run as a singletone as we, generally, do not need it.
  4. Doing some unittest refactoring and adding/removing appropriate tests.
    See work item 3334452.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nick863 nick863 requested a review from a team as a code owner July 9, 2024 23:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

promptflow-evals test result

  9 files  ±0    9 suites  ±0   2h 59m 49s ⏱️ +55s
 54 tests ±0   51 ✅ ±0   3 💤 ±0  0 ❌ ±0 
486 runs  ±0  459 ✅ ±0  27 💤 ±0  0 ❌ ±0 

Results for commit 7ee1ea2. ± Comparison against base commit 5a3396f.

♻️ This comment has been updated with latest results.

@nick863 nick863 requested review from ninghu and singankit July 10, 2024 23:26
@nick863 nick863 merged commit 2ba76d1 into main Jul 11, 2024
47 checks passed
@nick863 nick863 deleted the nirovins/make_eval_run_context_manager branch July 11, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singankit singankit singankit approved these changes

@ninghu ninghu ninghu approved these changes

Assignees
No one assigned
Labels
promptflow-evals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick863 @ninghu @singankit